Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix security group rule creation already exist #368

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

sebglon
Copy link
Contributor

@sebglon sebglon commented Sep 3, 2024

What type of PR is this?

/kind bug Fixes CreateSecurityGroupRule conflict.

What this PR does / why we need it:

Which issue(s) this PR fixes :
Fixes #349

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@sebglon sebglon marked this pull request as draft September 3, 2024 14:25
Copy link
Contributor

@outscale-hmi outscale-hmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@sebglon sebglon force-pushed the fix/sg-409-conflict branch from f3eebec to 803ac49 Compare September 3, 2024 15:26
@sebglon sebglon marked this pull request as ready for review September 3, 2024 15:37
@sebglon sebglon requested a review from outscale-hmi September 3, 2024 15:37
@outscale-hmi outscale-hmi merged commit 42e6213 into outscale:main Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SecurityGroup reconcide with OutboundRuleSecurityGroupIds fail
3 participants